Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 8 Next »

Background

This retro is for S57: Thursday, February 9th - Wednesday, Feb 22nd

Please add comments before the meeting! We’ll take a few minutes to add additional comments and discuss, then put together action items to operationalize suggestions.

Last sprints (S56) retro is here: 2023-02-08 (S56) Retrospective

Retrospective

S55 Discussion topics:

  • New thoughts on Draft PRs?

    • Joyce Sato-Reinhold took a different approach this sprint, she:

      • Only did 1 approach instead of multiple and very thoroughly documented her approach in comments on the PR (https://github.com/LiteFarmOrg/LiteFarm/pull/2461 )

      • Only Duncan reviewed the draft PR; one theory is when there are many PRs vying for your attention a draft one becomes de-prioritized

      • A few other approaches we could employ draft PRs for:

        • Sayaka Ono ‘s approach for work that’s “in progress” but not ready for approval

        • Jimmy’s approach for more experimental features that aren’t necessarily on the roadmap

      • Final guidance on using Draft PRs: use them if it helps your process!

  • Feedback on Mwaya’s unit testing guidance: Jest unit test guidance

    • Add a section on “what not to test”, what is the threshold to not create a test

    • Would be nice to know how are unit tests part of a more holistic testing strategy?

    • Would be nice to have a seed database with pre-made farms, users, crops, etc. that create a few baseline environments for testing. A few examples include “Farm with wild crops”, “Farm with paid and unpaid users”, etc.

    • Combine into this document / section? https://lite-farm.atlassian.net/wiki/spaces/LITEFARM/pages/1190428675/The+api+package#Backend-tests

  • Thoughts on a LiteFarm calendar for tracking OOO, meetings, and events?

    • Q: How would this incorporate folks without @litefarm.org email addresses?

Start doing

Stop doing

Keep doing

Shout outs

  • Some sort of automated process / notification whenever a PR is made that needs review

  • Kevin being in charge of merging; I feel like this introduces inefficiencies and should be owned by someone(s) closer to the code

  • Getting in bigger tickets early in the sprint loads of time for feedback which is great

Action items:

  •  

  • No labels