Versions Compared

Old Version 24

changes.mady.by.user Lite Farm

Saved on

compared with

New Version Current

changes.mady.by.user Duncan Brain

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • When you are satisfied that your work is ready for pre-integration peer review, create a PR from your branch to integration.

  • Your PR will trigger a set of automatic checks and tests. GitHub will show their status on the PR.

    If these checks find problems, address them by pushing more commits on your branch. They will append to your existing PR.

  • When the checks have passed, pre-integration peer review begins. The PR that you have just created is waiting for review by a teammate.

    1. The first reviewer is whichever teammate next submits a pull request of their own. This reviewer should assign themself as Reviewer on your PR so that everyone can see the review is in process.

    2. If the first reviewer does not agree that the PR meets expectations, they identify changes that need to be made and reject the PR with a request for those changes. You can submit these changes by pushing additional commits to your branch; they will be added to the existing PR where the first reviewer can evaluate them. This cycle can repeat until the first reviewer approves the PR.

    3. When the first reviewer agrees the PR meets expectations, they approve it and assign a second reviewer from a designated set of experienced LiteFarm developers. This may lead to more cycles of requested changes and new commits. In particular, the second reviewer will request any changes needed to resolve conflicts that prevent a clean merge with the integration branch.

    4. When the second reviewer approves the PR, they will merge it into theintegration branch, at this point the Github Jira integration should automatically update the ticket status from Development to Verification . The updated integration branch will build and deploy to the pre-production environment where verification and validation are performed. The second reviewer can be selected using the round robin automation on Github currently name LiteFarmOrg/reviewers

      View file
      nameInvalid file id - 8e5459e1-3504-4ca8-989a-3ef0ca3436cb

  • Notice that when you create a PR (previous bullet), you assume the role of first reviewer for the oldest waiting PR from someone else, and begin the process described under the previous bullet.