Page Comparison

1

Update the “edit individual expense” flow

Readonly view is disabled inputs

2

Update the “edit individual revenue” flow

Readonly view is disabled inputs

Number Input bugs (3):

3

The onChange handler (as far as I can tell) on AddExpense is buggy in Portuguese. This is the situation in which David Trapp was not able to enter a comma and the decimal cleared the whole input. This is specific to that Input and not the others.

Fix AddExpense value Input for Portuguese

Please test in Spanish and other comma-based decimal languages as well

4

Validation messages are not displaying when valueAsNumber is set to true (image from the new GeneralRevenue)

Relatedly the minimum validation for the current AddSale total field is flakey (sometimes the error message displays onBlur and sometimes doesn’t)

Fix validation messages for currency inputs

As below, the behaviour of the Unit (e.g. the Harvest Quantity of Edit Expense) is correct

From an initial look into the code, I think it’s actually an inherent behaviour of the (native) input once we’ve applied roundToDecimals from useUnit to the value

5

The handling of decimals in Add Sale and Edit Expense is mediocre. The behaviour of the Harvest Quantity component is ideal: decimals should become commas (when appropriate in that language) and rounding to two decimals should occur onBlur

Update finance currency Inputs to share the internationalization behaviour of Harvest Quantity (a <Unit /> component)

Getting ideal behaviour may or may not involve refactoring from an Input to a Unit