...
| tasks | notes | |||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
1 | Update the “edit individual expense” flow
| Readonly view is disabled inputs | |||||||||
2 | Update the “edit individual revenue” flow
| Readonly view is disabled inputs | |||||||||
Number Input bugs (3): | |||||||||||
3 | The onChange handler (as far as I can tell) on AddExpense is buggy in Portuguese. This is the situation in which David Trapp was not able to enter a comma and the decimal cleared the whole input. This is specific to that Input and not the others. | Fix AddExpense value Input for Portuguese
| Please test in Spanish and other comma-based decimal languages as well | ||||||||
4 | Validation messages are not displaying when valueAsNumber is set to true (image from the new GeneralRevenue) Relatedly the minimum validation for the current AddSale total field is flakey (sometimes the error message displays onBlur and sometimes doesn’t) | Fix validation messages for currency inputs
| As below, the behaviour of the Unit (e.g. the Harvest Quantity of Edit Expense) is correct | ||||||||
5 | The handling of decimals in Add Sale and Edit Expense is mediocre. The behaviour of the Harvest Quantity component is ideal: decimals should become commas (when appropriate in that language) and rounding to two decimals should occur onBlur | Update finance currency Inputs to share the internationalization behaviour of Harvest Quantity (a
| Getting ideal behaviour may or may not involve refactoring from an Input to a Unit |
...
What’s the relationship between the old Labour view and the new Labour expense tile? Is there a migration covering this? For now is the old Labour summary view removed?
Related comment:
Jira Legacy server System JIRA serverId 815f41e5-e5fb-3402-8587-82eccc3ffab0 key LF-3553
ticket to add type “Labour”:Jira Legacy server System JIRA serverId 815f41e5-e5fb-3402-8587-82eccc3ffab0 key LF-3564 Is estimated revenue removed? Where should it go now?? David Trapp
Are tooltips on the current finance page being carried over? Not in designs David Trapp
Does document export need to be recorded somewhere (e.g. in the database)?
Still need the following aspects of the Excel report:
What should the triggering flow look like (ticket 8 in the table directly above)
What does the report look like – we have full flexibility to style
Will we offer the option to email (e.g. as with farm map download)
Permissions on the API route?