...
Remaining revenue and expense flow tasks
Epic Link:
Jira Legacy | ||||||
---|---|---|---|---|---|---|
|
| tasks | notes | |||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1 | Update the “edit individual expense” flow
| Readonly view is disabled inputs | |||||||||||
2 | Update the “edit individual revenue” flow
| Readonly view is disabled inputs | |||||||||||
Number Input bugs (3): | |||||||||||||
3 | The onChange handler (as far as I can tell) on AddExpense is buggy in Portuguese. This is the situation in which David Trapp was not able to enter a comma and the decimal cleared the whole input. This is specific to that Input and not the others. | Fix AddExpense value Input for Portuguese
| Please test in Spanish and other comma-based decimal languages as well | ||||||||||
4 | Validation messages are not displaying when valueAsNumber is set to true (image from the new GeneralRevenue) Relatedly the minimum validation for the current AddSale total field is flakey (sometimes the error message displays onBlur and sometimes doesn’t) | Fix validation messages for currency inputs
| As below, the behaviour of the Unit (e.g. the Harvest Quantity of Edit Expense) is correct | ||||||||||
5 | The handling of decimals in Add Sale and Edit Expense is mediocre. The behaviour of the Harvest Quantity component is ideal: decimals should become commas (when appropriate in that language) and rounding to two decimals should occur onBlur | Update finance currency Inputs to share the internationalization behaviour of Harvest Quantity (a
| Getting ideal behaviour may or may not involve refactoring from an Input to a Unit |
...
Although this rework is visually substantial, most of the data is already present within three existing components, accessed via Finances, Actual Revenue, and Other Expenses
Note as revenue types is a new concept in Finances 2.0 we do not have organization by type in Actual Revenue. Other Expenses already contains this breakdown by type
Date filtering already works correctly via the
<DateRangeSelector />
“component” which controls thedate_range
within thefinancesReducer
slice of the storeHere and elsewhere you might notice that the container + pure component architecture is not always followed. It is preferred but not required for the dashboard tickets.
Please continue to use the old Redux architecture as it is functional
We are still waiting designs to be confirmed as final, so there is some risk of the visuals changing (noted below)
Note on the Figma Mockup: we are using the second panel of “Finances homescreen” as our current guide for the main homepage dashboard, with the addition of the date filtering from the third panel
Epic Links:
Jira Legacy server System JIRA serverId 815f41e5-e5fb-3402-8587-82eccc3ffab0 key LF-3624 Jira Legacy server System JIRA serverId 815f41e5-e5fb-3402-8587-82eccc3ffab0 key LF-3625
| tasks | notes | |||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
1 | Preliminary Dashboard Task | Convert the following class-based components into functional components:
| |||||||||
2 | Create reusable summary tile component
| Low risk (consistent throughout design document) | |||||||||
3 | Create/update existing transactions list
| Slight risk design might change, particularly the top and bottom table frame | |||||||||
4 | Create swipeable summary icon tiles component. Please use the existing icon tile component as your guide / base.
| Medium risk – consistent throughout design document BUT Duncan doesn’t like it and Loïc may not either | |||||||||
5 | Update
| Blocked by 1 Requires at least one of 2, 3, or 4 - ticket owner should feel free to subtask and apply whichever component(s) are available | |||||||||
6 | Update
| Blocked by 1 Requires at least one of 2, 3, or 4 - ticket owner should feel free to subtask and apply whichever component(s) are available Please do not implement “Last 30 days” filtering before checking in with product (it doesn’t appear on the homescreen tiles) | |||||||||
7 | Update
| Requires at least one of 2, 3, or 4 - ticket owner should feel free to subtask and apply whichever component(s) are available Please do not implement “Last 30 days” filtering before checking in with product (it doesn’t appear on the homescreen tiles) | |||||||||
8 | Build container and component to filter export report data. Add three-dots menu to Finances homescreen to trigger export.
| BLOCKED BY PRODUCT – Older design; I would prefer to get this confirmed before working. PDF export is not part of scope so that radio button should not exist | |||||||||
9 | Export structure / POC | Build saga, API route, controller, and utility function to generate and return an xlsx file
| See technical notes above. Only send and write to file three values (revenue, expenses, balance) and trigger download automatically as in current uploaded document functionality. | ||||||||
10 | Date Inputs in the | Update the Date inputs used in
| They probably can to be migrated to | ||||||||
| |||||||||||
| |||||||||||
|
|
...