...
Info |
---|
S55 Discussion topics:
Draft PRs: Joyce Sato-Reinhold attempted to do a draft PR this sprint as a way to get feedback from the team on an approach before getting too deep into a particular solution. In the end, the approach she thought would work didn’t so she ended up coding two solutions that both look like they’ll work. There are other solutions that she thinks will work, too. Concerned it may not be super readable since it’s very commented. Structuring it was pretty difficult too. Some things to consider:
Does this help your personal process?
Is the ticket impactful enough to code out several approaches?
Joyce did all of the different approaches in the same branch and thought this was easier. Could also potentially do them as different branches.
Sayaka always creates Draft PRs first, reviews her own code, and then switches it to ready when she’s happy with the solution.
Squash merges: We all agreed not to squash merges for now, because it’s not fun when you’re playing squash with someone and collide.
Start doing | Stop doing | Keep doing | Shout outs |
---|---|---|---|
|
|
|
Action items:
- Review draft PRs again next retro (specifically Joyce Sato-Reinhold 's PR on SSO)
- Review Mwaya’s unit testing guidance at next retro