...
Background
This retro is for S56: Thursday, January 26th - Wednesday, Feb 8th
...
S55 Discussion topics:
Draft PRs: Joyce Sato-Reinhold attempted to do a draft PR this sprint as a way to get feedback from the team on an approach before getting too deep into a particular solution. In the end, the approach she thought would work didn’t so she ended up coding two solutions that both look like they’ll work. There are other solutions that she thinks will work, too. Concerned it may not be super readable since it’s very commented. Structuring it was pretty difficult too. Some things to consider:
Joyce did all of the different approaches in the same branch and thought this was easier. Could also potentially do them as different branches.
Sayaka always creates Draft PRs first, reviews her own code, and then switches it to ready when she’s happy with the solution.
Squash merges: We all agreed not to squash merges for now, because it’s not fun when you’re playing squash with someone and collide.
Start doing | Stop doing | Keep doing | Shout outs |
|---|
| | Unit tests as part of scope of Jira tickets Good feedback on PRs Attention to detail and pride in your work Providing feedback on requirements that you think can be improved upon
| Thanks to Joyce Sato-Reinhold Craig Yu Ebert Mota and Navdeep Dhammu for getting PR’s in this sprint great work! 💯 Thanks to Gursimran Singh and Jawadur Rahim (Unlicensed) for keeping at it and asking for help when needed! Great job Sayaka Ono for adding backend testing to your PR’s so far! After a bit of practice I would love to start doing this too! Great job Duncan Brain helping to grow the community and encourage and enable new contributors! Shout out to Mwayanjana Bolokonya (Unlicensed) for taking sick time when he needed it. LiteFarm will be here when you’re feeling better  Big props to Yu Tian for his deep and broad knowledge of all things software and for being an active reviewer in the community Thanks to Yu Tian for identifying the problem with the export server and provided a solution. Also thanks to Duncan Brain Orangel Marquez and Kevin for guiding me through the back-end system. Shout out to Craig Yu for fixing the export server and incorporating it into the build process - that’s one big infrastructural hurdle off the roadmap 💥 Thank you Duncan Brain and Sayaka Ono for always being so available and helpful with issues and questions and reviews (when do you have the time to work on your own tickets???!) I appreciate your hard work on non-coding stuff (and reviewing and coding of course) Duncan Brain
|
Action items:
- Review draft PRs again next retro (specifically Joyce Sato-Reinhold 's PR on SSO)
- Review Mwaya’s unit testing guidance at next retro