Page Comparison

creating

the https://lite-farm.atlassian.net/wiki/spaces/LITEFARM/pages/658309153/Unit+displays#Default-display-guidance should determine the value / unit combination

the user set unit preference should be used

What is the “user set unit preference”? Is it a record-to-record unit(a record has not been created on a creation view) or user’s farm unit system preference (metric/imperial)?

read-only

the https://lite-farm.atlassian.net/wiki/spaces/LITEFARM/pages/658309153/Unit+displays#Default-display-guidance should be used
Once pre-populated value is modified, is it considered as a “user created” value? Currently, even if I change the unit to “ft²” and save, “ac” is still shown. Is it a bug?

the user set unit preference should be used

editing

the https://lite-farm.atlassian.net/wiki/spaces/LITEFARM/pages/658309153/Unit+displays#Default-display-guidance should be used

the user set unit preference should be used

backfill data

find wrong data and write a script

database

no change required

APIs

• [POST] convert received values to “stored as” values for each endpoint and store (create a helper or middleware)

• [GET] convert saved values to “display” values before sending to a client (create a helper or middleware)

• add tests for each endpoint

no change required

frontend

• remove logic from the Unit component (make it a presentation component)

• create a hook to handle logic, and add comments to make it clear what the code does (this still needs to calculate what the values would be when stored in the database)

• remove logic from the Unit component (make it a presentation component)

• create a hook to handle logic, and add comments to make it clear what the code does (this includes data conversion when submitting or showing data)

• write tests for each unit input

auto conversion
(optional)

DB: need migration (auto conversion property in the userFarm table)
(UI: modify the user setting view to set “auto conversion”)

backend: update the helper or middleware to take user setting into account

frontend: update the hook to take user setting into account

pros

• some logic can be removed from the frontend

• the logic is in one place and could avoid small errors for adding lines all over the files

• no need to test APIs

cons

• frontend still needs to take care of some calculations

• need to update many APIs and their tests

• QA needs to test APIs + UI

• should be careful not to make the same mistakes (no more rework…)

1

extract logic from the current unit component and create a hook

feature branch

2

2

update the unit component to make it work as a presentation component

feature branch

2

3

fix the logic in the hook

feature Check:

1. Does the display unit match the system of measure (e.g. cm and imperial)? If no, jump to #3

2. Does the user specify the unit (within the system of measure), use that unit

3. Otherwise: Display default for value

feature branch

8

4

test all instances and make adjustments and fix issues (hopefully write tests)

• What about calculated values? (e.g. water use calculator)

feature branch, and then create a PR against integration branch

8

- 13

5

Pop-up when changing system of measure at your farm warning that everything will default based on the value.

integration